Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-55264] Prevent call post from being modified #608

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

streamer45
Copy link
Collaborator

Summary

PR prevents the call post from being modified as it could cause issues like messing with metadata such as recording file ids.

More context in the original comment #549 (comment)

Ticket Link

https://mattermost.atlassian.net/browse/MM-55264

@streamer45 streamer45 added 2: Dev Review Requires review by a core committer 3: Security Review labels Jan 3, 2024
@streamer45 streamer45 added this to the v0.23.0 / MM 9.5 milestone Jan 3, 2024
@streamer45 streamer45 requested a review from cpoile January 3, 2024 22:25
@streamer45 streamer45 self-assigned this Jan 3, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1d769ec) 7.85% compared to head (22e976d) 7.84%.

Files Patch % Lines
server/plugin.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #608      +/-   ##
========================================
- Coverage   7.85%   7.84%   -0.01%     
========================================
  Files         26      26              
  Lines       5217    5223       +6     
========================================
  Hits         410     410              
- Misses      4762    4768       +6     
  Partials      45      45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streamer45 streamer45 requested a review from jupenur January 4, 2024 16:01
@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: Security Review labels Jan 8, 2024
@streamer45 streamer45 merged commit f19420b into main Jan 9, 2024
4 checks passed
@streamer45 streamer45 deleted the MM-55264 branch January 9, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants