[MM-58292] Suppress push notifications to call thread if receiver is in call #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
Jul 5, 2024
| @@ -215,3 +215,34 @@ func (s *Store) GetCallSessionsCount(callID string, opts GetCallSessionOpts) (in | |||
|
|
|||
| return count, nil | |||
| } | |||
|
|
|||
| func (s *Store) IsUserInCall(userID, callID string, opts GetCallSessionOpts) (bool, error) { | |||
There was a problem hiding this comment.
What do you think of the performance impact of this approach? I guess we don't really have any other option, and it's not an event that will happen too often, but just curious.
There was a problem hiding this comment.
@cpoile I'd expect this to be extremely efficient, given that callID is an index and the sessions table is very small. Plus the query doesn't need to return any structured data. The only further optimization would be an index on calls_sessions.userid, but given the premise (small table + filter on call), it's not worth it since a scan will be the best option anyway. To put it in comparison, I think it could be more costly the RPC hook call itself than the DB query.
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR adds some logic to suppress mobile push notifications for replies to a call thread if the receiver is in that call. This is to mimic (see note) the behavior of the web/desktop client-side hook.
Note: I haven't found an easy way to check for mentions, so we'd be disabling any type of notification, which I find reasonable for the call thread, given the user should have the app open somewhere.
Ticket Link
https://mattermost.atlassian.net/browse/MM-58292