Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #828

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Fix flaky test #828

merged 2 commits into from
Aug 2, 2024

Conversation

streamer45
Copy link
Collaborator

Summary

Working with dates is a bit tricky. Test could fail based on which day of the month we were on.

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Aug 1, 2024
@streamer45 streamer45 added this to the v1.0.0 🚀 / MM 10.0 milestone Aug 1, 2024
@streamer45 streamer45 requested a review from cpoile August 1, 2024 10:29
@streamer45 streamer45 self-assigned this Aug 1, 2024
@streamer45
Copy link
Collaborator Author

It's one of those weeks...pipeline is broken after some update it seems.

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 Thanks!

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 1, 2024
@streamer45 streamer45 merged commit c2ea14a into main Aug 2, 2024
18 checks passed
@streamer45 streamer45 deleted the flaky-test branch August 2, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants