Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-59070] Add telemetry events for host controls #831

Merged
merged 10 commits into from
Aug 13, 2024
Merged

[MM-59070] Add telemetry events for host controls #831

merged 10 commits into from
Aug 13, 2024

Conversation

streamer45
Copy link
Collaborator

Summary

Adding some telemetry tracking for the recently added host control feature.

@ifoukarakis We are not sending any additional application-specific data other than the event because I am not sure it's needed (e.g., CallID). Of course, we are including the correct SKUs as agreed before.

Ticket Link

https://mattermost.atlassian.net/browse/MM-59070

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Aug 5, 2024
@streamer45 streamer45 added this to the v1.0.0 🚀 / MM 10.0 milestone Aug 5, 2024
@streamer45 streamer45 self-assigned this Aug 5, 2024
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 Thank you 🙇

@ifoukarakis
Copy link

We are not sending any additional application-specific data other than the event because I am not sure it's needed (e.g., CallID). Of course, we are including the correct SKUs as agreed before.

These can be added later if we have requirements for tracking specific flows. The benefit of keeping it minimal is that we don't overload property names unless needed.

CC @catalintomai

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 12, 2024
Base automatically changed from MM-57781 to main August 13, 2024 06:24
@streamer45 streamer45 merged commit 5a53a0b into main Aug 13, 2024
19 checks passed
@streamer45 streamer45 deleted the MM-59070 branch August 13, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants