Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-61358] Fix flaky test job #894

Merged
merged 2 commits into from
Oct 29, 2024
Merged

[MM-61358] Fix flaky test job #894

merged 2 commits into from
Oct 29, 2024

Conversation

streamer45
Copy link
Collaborator

@streamer45 streamer45 commented Oct 29, 2024

Summary

Somehow the parallelism (plus testcontainers) isn't playing nicely with Github CI. At this point, the flakiness is not worth the speedup (a couple of minutes).

Ticket Link

https://mattermost.atlassian.net/browse/MM-61358

@streamer45 streamer45 self-assigned this Oct 29, 2024
@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Oct 29, 2024
@streamer45 streamer45 requested a review from cpoile October 29, 2024 20:51
@streamer45 streamer45 marked this pull request as ready for review October 29, 2024 20:51
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 29, 2024
@streamer45 streamer45 merged commit 0360ee0 into main Oct 29, 2024
19 checks passed
@streamer45 streamer45 deleted the MM-61358 branch October 29, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants