Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky AV1 e2e #932

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix flaky AV1 e2e #932

merged 1 commit into from
Dec 20, 2024

Conversation

streamer45
Copy link
Collaborator

Summary

The AV1 e2e tests have been failing too often for my liking, so we are trying something slightly different and hopefully more consistent.

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Dec 20, 2024
@streamer45 streamer45 requested a review from cpoile December 20, 2024 18:29
@streamer45 streamer45 self-assigned this Dec 20, 2024
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to make some smarty-pants comment that instead of stats.forEach(...) you could use a stats.find(.., but it really won't make much of a difference. :)

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Dec 20, 2024
@streamer45
Copy link
Collaborator Author

I was going to make some smarty-pants comment that instead of stats.forEach(...) you could use a stats.find(.., but it really won't make much of a difference. :)

@cpoile Sadly it won't work because stats is not an array. It's this weird map like object that requires looping with forEach.

See https://developer.mozilla.org/en-US/docs/Web/API/RTCStatsReport if you are curious.

@cpoile
Copy link
Member

cpoile commented Dec 20, 2024

Oh, well good thing I didn't make that comment then! :)

@streamer45 streamer45 merged commit 3a9a479 into main Dec 20, 2024
19 checks passed
@streamer45 streamer45 deleted the fix-flaky-e2e branch December 20, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants