This repository has been archived by the owner on May 27, 2024. It is now read-only.
Support changeable configuration file location #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using many folders like config, commands and scripts. Changing workdir to `/opt/ops-tool` will allow us to access those folders relatively. Signed-off-by: Mustafa Kara <[email protected]>
ghost
linked an issue
Signed-off-by: Mustafa Kara <[email protected]>
ghost
force-pushed
the
feat/33-modify-dockerfile-working-directory
branch
from
10c37b5 to
53d13c1
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Configuration file location is hardcoded in the codebase, which prevent users to change it's location to somewhere else.
Dockerfile work dir is configured as
/opt/ops-tool/binwhich makes us to define every folder under bin folder. Docker folder structure:We need to map or create other folders under
/opt/ops-tool. For that docker workdir is changed.Ticket Link
Fixes: #33