This repository has been archived by the owner on May 27, 2024. It is now read-only.
Plugins are not built and included in the Docker Image #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
linked an issue
ghost
force-pushed
the
fature/35-improve-makefile-to-build-and-distribute-plugins
branch
from
5686e1b to
c8ad5bc
Compare
Signed-off-by: Mustafa Kara <[email protected]>
ghost
force-pushed
the
fature/35-improve-makefile-to-build-and-distribute-plugins
branch
from
c8ad5bc to
6a6c37d
Compare
ghost
commented
Aug 12, 2022
| @@ -4,15 +4,15 @@ listen: "0.0.0.0:8080" | |||
| base_url: "https://op-tools-address.com" | |||
| plugins: | |||
| - name: bash_useful | |||
| file: plugins/bash.so | |||
| file: dist/plugins/bash.so | |||
There was a problem hiding this comment.
Sample configuration is changed since build generates plugins in dist folder at repository. So make go-run will work when user executes the project from code base.
phoinixgrr
approved these changes
Aug 12, 2022
spirosoik
approved these changes
Aug 12, 2022
ghost
deleted the
fature/35-improve-makefile-to-build-and-distribute-plugins
branch
|
Awesome thanks! |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We enabled plugin support for OpsTool. But those images were not included in the builds and generating containers. Cause of it we are generating unusable docker images.
PR contains changes to build every plugin and include them in the container.
Plugin artifacts will be stored under
dist/pluginsfolder.To configure a plugin in the builds:
OPS_TOOL_PLUGINSlist.CGO_ENABLED=1
We started to build with CGO_ENABLED cause plugin builds needs that configuration since plugins requires dynamic linker.
Details are here: golang/go#19569
Docker image change
At Distroless image bash is not installed and our bash plugin fails. To make bash plugin work and not build docker image frequently (cause of bash plugin and command needs), changed runner base image to debian.
Ticket Link
Fixes #35