Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-59548] Fix potentially stuck goroutines #151

Merged
merged 5 commits into from
Jul 18, 2024
Merged

[MM-59548] Fix potentially stuck goroutines #151

merged 5 commits into from
Jul 18, 2024

Conversation

streamer45
Copy link
Contributor

Summary

Looking at goroutines profiles highlighted a couple of (unrelated) issues:

  1. Some read calls on incoming voice tracks can suddenly block due to an apparent regression upstream (pion/transport).
    • This is still under investigation. Downgrading to the previous version is enough to prevent the issue while a fix is found.
  2. The CloseSession could get stuck indefinitely in case of a timeout during the initial signaling phase due to a circular check on the session's done channel.
    • Reworked the function to preemptively close the channel in these fail-early cases.

Ticket Link

https://mattermost.atlassian.net/browse/MM-59548

@streamer45 streamer45 added 2: Dev Review Requires review by a core committer Do Not Merge Should not be merged until this label is removed labels Jul 18, 2024
@streamer45 streamer45 added this to the v0.16.2 milestone Jul 18, 2024
@streamer45 streamer45 requested a review from cpoile July 18, 2024 13:40
@streamer45 streamer45 self-assigned this Jul 18, 2024
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, tricky. Nice fix. 🎉

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jul 18, 2024
@streamer45 streamer45 removed the Do Not Merge Should not be merged until this label is removed label Jul 18, 2024
@streamer45 streamer45 merged commit 4ea4023 into master Jul 18, 2024
2 checks passed
@streamer45 streamer45 deleted the MM-59548 branch July 18, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants