Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-62410] Implement API handler to fetch session config #166

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

streamer45
Copy link
Contributor

Summary

PR implements a new /calls/{callID}/sessions/{sessionID} HTTP API endpoint to let clients access information about a specific session (its config). This will enable the plugin side to know whether a session exists and help deal with potential inconsistencies (e.g., stuck calls).

Ticket Link

https://mattermost.atlassian.net/browse/MM-62410

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Jan 8, 2025
@streamer45 streamer45 added this to the v1.0.0 milestone Jan 8, 2025
@streamer45 streamer45 requested a review from cpoile January 8, 2025 11:59
@streamer45 streamer45 self-assigned this Jan 8, 2025
@streamer45
Copy link
Contributor Author

Added a new handler to get all the sessions for a given call since it's a little more efficient for the current use case.

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward, thanks!

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 10, 2025
@streamer45 streamer45 merged commit 10a4dd9 into master Jan 10, 2025
2 checks passed
@streamer45 streamer45 deleted the MM-62410 branch January 10, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants