remove unused code #1227
Merged
remove unused code #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waleedka
reviewed
Jan 28, 2019
|
The PR looks good. Thanks! The only issue is the comment I left above. I can see how it could be confusing, but I also think it could be more confusing without the explicit -1 + 1. |
This reverts commit b5c51c5.
|
@waleedka Thank you for the feedback! I have reverted the removal of |
|
Thank you! |
luccauchon
added a commit
to luccauchon/Mask_RCNN
that referenced
this pull request
Feb 4, 2019
* Fix visualize activations (matterport#1211) Fix visualize activations (Squashed 4 commits by @keineahnung2345) # Get activations of a few sample layers activations = model.run_graph([image], [ ("input_image", model.keras_model.get_layer("input_image").output) ]) leads to the error: InvalidArgumentError: input_image:0 is both fed and fetched. Revise the code according to https://stackoverflow.com/questions/39307108/placeholder-20-is-both-fed-and-fetched * Fix typo in config.py * Fix typo in rpn_class_loss_graph Fix matterport#870 * Reversed order (1) and (2) in installation Reference to matterport#1255 * remove unused code (matterport#1227) Remove unused code
Closed
aneeshchauhan
pushed a commit
to aneeshchauhan/Mask_RCNN
that referenced
this pull request
Jul 9, 2019
Remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the following unused code:
in
mrcnn/model.py:(line 529)
crowd_masks = tf.gather(gt_masks, crowd_ix, axis=2)in
mrcnn/visualize.py:(line 143 & 439)
x = random.randint(x1, (x1 + x2) // 2)This PR modifies the following redundant code:
in
mrcnn/model.py:(line 2264)
self.epoch = int(m.group(6)) - 1 + 1changes toself.epoch = int(m.group(6))