-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process C extensions inside namespace packages #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
added a commit
to lpsinger/ligo.skymap
that referenced
this pull request
Jun 11, 2018
lpsinger
force-pushed
the
namespace-packages
branch
from
October 2, 2018 19:28
8093456
to
39b4d10
Compare
When a wheel contains subpackages of a namespace package, there is no `__init__.py` file for the namespace package, though its subpackage directories do contain `__init__.py` files. When scanning the wheel for package directories, searching the root for directories that contain `__init__.py` files is insufficient because we will miss C extension modules that are subpackages of namespace packages. Instead, we need to do a depth-first traversal of the directory tree and capture the most shallow directories that contain `__init__.py` files.
lpsinger
force-pushed
the
namespace-packages
branch
from
February 7, 2019 13:52
39b4d10
to
366eb0c
Compare
rowillia
pushed a commit
to rowillia/delocate
that referenced
this pull request
Feb 24, 2021
Namespace packes do not have a top level `__init__.py` - https://packaging.python.org/guides/packaging-namespace-packages/#native-namespace-packages This causes delcoate to fail to find those packages. setuptools will store the those values in `*.dist-info/namespace_packages.txt` https://github.com/pypa/setuptools/blob/main/setup.py#L139 matthew-brett#38 blindly globbed everything, this approaches it in a more compliant way.
rowillia
pushed a commit
to rowillia/delocate
that referenced
this pull request
Feb 24, 2021
Namespace packes do not have a top level `__init__.py` - https://packaging.python.org/guides/packaging-namespace-packages/#native-namespace-packages This causes delcoate to fail to find those packages. setuptools will store the those values in `*.dist-info/namespace_packages.txt` https://github.com/pypa/setuptools/blob/main/setup.py#L139 matthew-brett#38 blindly globbed everything, this approaches it in a more compliant way.
PR #123 was merged which has fixed this issue and includes tests for namespace packages. |
Nice! This worked for my package. Thank you! |
lpsinger
added a commit
to lpsinger/ligo.skymap
that referenced
this pull request
Sep 24, 2021
matthew-brett/delocate#38 has been fixed upstream.
Ceciliogq
pushed a commit
to Ceciliogq/lalsuite
that referenced
this pull request
Oct 15, 2021
The issues that required using a fork have been fixed upstream. See matthew-brett/delocate#38. Fixes #472.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a wheel contains subpackages of a namespace package, there is no
__init__.py
file for the namespace package, though its subpackage directories do contain__init__.py
files.When scanning the wheel for package directories, searching the root for directories that contain
__init__.py
files is insufficient because we will miss C extension modules that are subpackages of namespace packages.Instead, we need to do a depth-first traversal of the directory tree and capture the most shallow directories that contain
__init__.py
files.