Replacing colored by colorize

[osiro]

Hey guys,

Looks like colored doesn't play nice when we've got any other gem depending on colorize.

It blows up with the following error:

.../gems/colored-1.2/lib/colored.rb:70:in `colorize': no implicit conversion of Hash into String (TypeError)

Considering colored is not being maintained (or at least it looks like it's not), I would suggest using colorize instead.

This pull also fixes https://travis-ci.org/mattheworiordan/capybara-screenshot/jobs/46012046

[mattheworiordan]

Thanks for this, however you need to consider #93 first. I actually think, given how little colored or colorize does, that the best approach would be to simply create some helper methods to add colour and remove this dependency. What do you think?

[osiro]

Hum.... true, hadn't seen #93 before opening this pull...

Give me a few days and I can make it works without colorize or colored.

[mattheworiordan]

Great, thanks

Regards,
Matthew

Sent from my phone

On 16 Jan 2015, at 02:17, Vinicius Osiro [email protected] wrote:

Hum.... true, hadn't seen #93 before opening this pull...

Give me a few days and I can make it works without colorize or colored.

—
Reply to this email directly or view it on GitHub.

[mattheworiordan]

Hey @osiro, seems someone else has this same issue, see #115. Did you make any progress on this?

[fbernier]

Hitting the same issue here when updating capybara-screenshot because of one of our bundled gem.

[mattheworiordan]

@fbernier I'm pretty flat out right now, what to give it a go doing a PR to fix it? Given the limited color functionality, it should be easy enough to add custom color methods and remove the dependency altogether I suspect.

[mattheworiordan]

This is resolved with #118