Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specs to work with Capybara 3+ #236

Merged
merged 1 commit into from
Oct 21, 2018

Conversation

noniq
Copy link
Contributor

@noniq noniq commented Aug 24, 2018

In Capybara 3 the error message was changed from „Unable to find visible link or button …” to “Unable to find link or button …”.

This commit is a backward-compatible fix, so that the specs now work with both Capybara 2 and Capybara 3.

In Capybara 3 the error message was changed from „Unable to find visible link or button …” to “Unable to find link or button …”.

This commit is a backward-compatible fix, so that the specs now work with both Capybara 2 and Capybara 3.
Copy link
Owner

@mattheworiordan mattheworiordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I appreciate this.
I do think we should have another gemset for tests with Capybara 2 and 3, however I don't think that should block this PR. So I'll merge and raise an issue to do this later.
Thanks so much for the contribution.

@mattheworiordan mattheworiordan merged commit 30fe232 into mattheworiordan:master Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants