Support additional browser backends + refactoring #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport for embed() call for cucumber.
|
Wow, thanks for putting in the time for this gem. I will go through the code when I have a chance and do some testing before I merge the pull request, but unless I find any issues, I will definitely incorporate. Thanks again. |
| @@ -1,22 +1,51 @@ | |||
| module Capybara | |||
| module Screenshot | |||
| class Saver | |||
There was a problem hiding this comment.
I changed this away from a class to a module. Since we don't have any internal state, there is no need to use a class :)
|
Added some comments to make the changes more clear. |
mattheworiordan
pushed a commit
that referenced
this pull request
Nov 24, 2011
Support additional browser backends + refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "large" change and some of the refactorings might be somewhat opinionated.
This allows people to test on non-rails projects (e.g. when testing external webapps) using the selenium/capybara-webkit/poltergeist drivers.
I hope I didn't break any of the non-cucumber or rails related things.
Cheers,
Marc