Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue #17

Closed
wants to merge 1 commit into from
Closed

Fix build issue #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export default function(options) {
}
}
},
'astro:build:start'({ buildConfig }) {
'config.build'({ buildConfig }) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a real hook, what made you think to do this change?

Copy link
Author

@romanzy313 romanzy313 Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the link I attached in original PR.

    The deprecation of the buildConfig option in astro:build:start in favor of moving those same options to config.build.

It wont build using latest stable Astro version

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. That is saying that the build is on the config.build object, not the config.build hook. I'll submit another PR to fix.

args.clientRelative = relative(fileURLToPath(buildConfig.server), fileURLToPath(buildConfig.client));
}
}
Expand Down