Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: socket + post with data #35

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

AceCodePt
Copy link
Contributor

Hi!

Found 2 problems:

  1. making POST requests to pages with data (in any non empty format) doesn't return.
  2. When using the @fastify/websocket, the vite websocket runs partially on fastify.

Fixed them.

However:
With these changes.,only the requests that were explicit towards fastify will be caught,
unlike the previous version where all was caught.

Upside:
I believe this is slightly faster then the previous algorithm, because we are dividing only for relevancy.

@AceCodePt AceCodePt force-pushed the bugfix/websocket-post-data branch from cf45805 to 39bb930 Compare February 21, 2024 21:16
@AceCodePt
Copy link
Contributor Author

@matthewp It doesn't support all the ways to encode information,
but it is a nice start.
Waiting on you mate :)

* chore: changed the name of the package

* chore: changed tag

* chore: mistake with undici

* chore: returned package
@tdnordine
Copy link

I need this fix for a project that I am working on, just to add an additional data-point. These changes work for my situation.

@AceCodePt
Copy link
Contributor Author

I need this fix for a project that I am working on, just to add an additional data-point. These changes work for my situation.

for the mean while: @tdnordine
pnpm i AceCodePt/astro-fastify#bugfix/websocket-post-data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants