for convert_* functions, allow for tags with special characters in their name (like "subtag-name") #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fess-AKA-DeadMonk - thanks for submitting this pull request! I have two suggestions:
|
|
@Fess-AKA-DeadMonk - if you are able to make the changes suggested above, we can review and approve this pull request. Thanks! |
chrispy-snps
changed the title
…symbols not suitable for python def html tags may contain symbols like `:` and `-` which are not suitable for the python function names simple name converter allows usage of the methods for tags like `tag:subtag-name`
chrispy-snps
force-pushed
the
develop
branch
2 times, most recently
from
a2f4c3b to
bd4c46d
Compare
Signed-off-by: chrispy <[email protected]>
|
@Fess-AKA-DeadMonk - the support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
html tags may contain symbols like
:and-which are not suitable for the python function namessimple name converter allows usage of the methods for tags like
tag:subtag-name