Fix the bugs of generating topojson with complicated geojson #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the test again with proper path and debug the code.
This time there are three fails in all test:
Two fails are related to test_extract in the assertion of intermediate dict structure. I think these fails are inevitable since I changed the process structure of feature and geometry collections.
One fail is related to
test_topology_to_geojson_nested_geometrycollection
intest_topology
. This is also an assertion fail as in my process, I changed the geojson structure of nested geometrycollection, so it cannot be reverted to the same geojson after it is converted to topojson. But as far as I read the generated geojson, I think they can refer to the original geojson with the same geometry.I am sorry that I cannot solve the remaining fails since they are much related to other data structures. But I think at least this adaption can be utilized for generating topojson from geojson with attributes. I am not sure whether to merge it or not, so I leave the decision to the maintainers.