Improve serialization of geopandas objects and code cleaning #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly targets the
topojson.core.extract.py
file.It refactors the parsing of GeoDataFrames and GeoSeries. Now a GeoDataFrame is serialized from
gdf.to_dict(orient='records')
and a GeoSeries fromseries.to_dict()
. No need to go through the much slower__geo_interface__
.Also this PR prepend non public attributes and functions in the
Extract
class with a_
.And because I removed the
options
object out of the.options
, Ihad to change some other classes and tests as well.Also more docstrings are included.