Develop 162 draft wrapper #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattldawson
commented
Oct 19, 2022
src/chemistry/mozart/mo_tuvx.F90
Outdated
Comment on lines
123
to
131
| #ifdef _OPENMP | ||
| use omp_lib, only : omp_get_thread_num | ||
| #endif | ||
|
|
||
| #ifdef _OPENMP | ||
| thread_id = omp_get_thread_num( ) | ||
| #else | ||
| thread_id = 1 | ||
| #endif |
There was a problem hiding this comment.
@fvitt - is this the right way to know if OpenMP is being used? It doesn't seem to be used in the modeling2 configuration I've been using, but I saw code similar to this in other parts of CAM
K20shores
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes ESCOMP#162 on TUV-x repo.
Includes wrapper for TUV-x in CAM with initialization and finalization functions. TUV-x cores are initialized for each OpenMP thread and each MPI task.
Temporarily copies TUV-x configuration data to run directory for use during development until https://github.com/NCAR/tuv-x/issues/163 is completed.
Linking the TUV-x, json-fortran, and musica libraries required a minor modification to CMEPS. I will follow up with CIME developers to see if there is a better way to do this.
FOLLOW UP: I met briefly with Jim Edwards and showed him this approach to build the libraries. He said it looked ok high-level, and that we can submit a PR to CMEPS for the modification and they would go over it in more detail then.