Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ts type definitions #7

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Add ts type definitions #7

merged 2 commits into from
Jan 24, 2019

Conversation

mattphillips
Copy link
Owner

What

Add type definitions for core Jest matchers and jest-extended matchers to return the matcher object

Why

#4

Notes

I'm not convinced by this change and would like help investigating if we can dynamically re-assign all properties of an interface to a new return type.

That way all other definitions we just work out of the box and the types won't need to be managed by hand with every change in core/jest-extended

@codecov-io
Copy link

codecov-io commented Oct 25, 2018

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          15     15           
  Branches        2      2           
=====================================
  Hits           15     15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ce879...2f8fb50. Read the comment docs.

@fgkramer
Copy link

Hi,
Is there something I can do to help getting this merged?

@mattphillips
Copy link
Owner Author

@fgkramer @natealcedo @byCedric

I've now played with TS a bit and think I may have just cracked this problem without the need for hand crafted types!

Would you be able to look at the PR and maybe even pull it down and link it to a project (yarn link) and see if this solves the problem? Cheers

@mattphillips
Copy link
Owner Author

In fact I've just yarn linked it locally and seems to be working - I'll go ahead and merge/publish this :)

@mattphillips mattphillips merged commit 8f200b7 into master Jan 24, 2019
@fgkramer
Copy link

Amazing, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants