Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more Page methods #222

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Expose more Page methods #222

merged 3 commits into from
Jul 8, 2024

Conversation

johnvictor1965
Copy link
Contributor

@johnvictor1965 johnvictor1965 commented Jul 6, 2024 •
edited
Loading

Despite being implemented in Target, Puppeteer's authenticate() API is not available for regular Page users. This PR adds a new target message to port that. Same goes for opener_id().

@johnvictor1965
Copy link
Contributor Author

Closes #145

mattsse
mattsse approved these changes Jul 8, 2024
View reviewed changes
Copy link
Owner

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
one q re removed targetconfig function,
I think this is probably unused but removing this would be a breaking change

src/handler/target.rs Show resolved Hide resolved
@johnvictor1965 johnvictor1965 changed the title Page::authenticate() Expose more Page methods Jul 8, 2024
@johnvictor1965
Copy link
Contributor Author

I just added another one. And renamed Target::opener() to Target::opener_id(). Would that be a breaking change despite no one actually using Target in user code?

mattsse
mattsse approved these changes Jul 8, 2024
View reviewed changes
Copy link
Owner

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems fine, I don't think this is used manually

@johnvictor1965
Copy link
Contributor Author

Lemme just fix those imports for you

@mattsse mattsse merged commit 0897fb5 into mattsse:main Jul 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnvictor1965 @mattsse