-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure remote paths #68
Conversation
2079599
to
cad615a
Compare
Codecov ReportBase: 99.55% // Head: 99.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 99.55% 99.58% +0.02%
==========================================
Files 6 6
Lines 225 239 +14
Branches 46 51 +5
==========================================
+ Hits 224 238 +14
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This is awesome! I've just pushed up a prerelease to test. There was one comment that seems to have snuck in to your commits, but I'll run the prerelease for a couple days and once that's addressed this looks good to merge! |
Cheers, I missed running the tests again and forgot before I pushed. |
61a84b2
to
92c2339
Compare
Adds a new Environment Variable
PRIMARY/SECONDARY...PATH
for primary and secondary serversThis is quite noisy, but I hope I can make up by making sure it's at least well tested....
I tried a simpler approach, but while it worked it left some confusion in the codebase around
baseUrl
, so I've moved everything to usefullUrl
and now we have bothpath
andbaseUrl
as two separate values. This can be undone if it seems unnecessary.I've tried to ensure that I catch as many backward compatibility tests it needs, such as if people are already providing some path within their
baseUrl
(because the need here was to remove the default/admin
value only). I've made the assumption that there are people out there who may already be defining some path values in theirbaseUrl
, this approach should not cause any impact for them.I've never used typescript and I'm not really a practiced JS developer, so let me know if anything seems out of place or where I could make improvements.
Closes #62