[#67] Make first video play manual #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a canPlay method to player interface - Add canPlay implementations for Dummy and Youtube players - Add Youtube playing restriction to have played manually any video per user every three hours - Add a canLoop method to loop manager to use the canPlay method and make sure to return the promises every step of the chain so we can handle when the canPlay promise is rejected - Update the loading of videos to not automatically play them. This is used on Lesson creation and works fine because cue-ing the video fetches the duration, which was a requirement on Lesson creation and thus simplifies enforcing the restriction on load. Playing will always come from manual play in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67.
Ask the user to play YouTube videos manually every 3 hours (hardcoded for now) to make plays count towards video views.