Refactor Range Controller #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The missing bind prevents the function from being able to call dispatch since the this isn't the player controller.
- Extract Zoom tracking functionality to a ZoomManager class - Move events related to zoom addition/removal from the Range Controller to the Zoom controller to drive zoom changes via the ZoomManager - Unify Range's dispatch events to one event called `rangeInputUpdated` which can be reacted to by interested controllers. Actions in the respective controller elements are updated. - Update the Range Controller tests to include the zoom outlet it now requires. The specs are left largely as they were and some tests are moved to Zoom Manager tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract zoom-related functionality from the Range Controller and handle outgoing/incoming events better: