Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#92] Enable New Section button when the video has loaded #93

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mauriciofierrom
Copy link
Owner

Closes #92

  • Turn link into a button with the styles of a link button
  • Fix styles for the sections content to flex by column and align contents by the start
  • Add e2e test by simulating a 1 second load in the Dummy Player by setting a flag in local storage

@mauriciofierrom mauriciofierrom changed the title Enable New Section button when the video has loaded [#92] Enable New Section button when the video has loaded Jan 29, 2025
- Turn link into a button with the styles of a link button
- Fix styles for the sections content to flex by column and align
  contents by the start
- Add e2e test by simulating a 1 second load in the Dummy Player by
  setting a flag in local storage
@mauriciofierrom mauriciofierrom force-pushed the 92-disable-new-section-until-video-loaded branch from 49c4bc2 to a098417 Compare January 29, 2025 04:27
@mauriciofierrom mauriciofierrom merged commit 2dfc4a4 into main Jan 29, 2025
1 check passed
@mauriciofierrom mauriciofierrom deleted the 92-disable-new-section-until-video-loaded branch January 29, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable "New Section" button until video is loaded
1 participant