fix(types): Fix build/typedoc errors, flatten types for d3Scale #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ignore type-checking for `d3Scale[this.options.xAxis.type]()`: typescript cant compare the signatures, see microsoft/TypeScript#33591 - ignore `number[]` as a return type of `ScaleContinuousNumeric.domain(<domain>)`, another typescript limitation
leonhma
commented
Aug 19, 2022
|
sorry for leaving this PR open, it got lost in my inbox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some limitations with typescript (microsoft/TypeScript#33591) the
this.meta.xScale = d3Scale[this.options.xAxis.type]()line kept giving type errors. As per suggested in this issue, I did some type-flattening and now there are no more errors.