Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful handling of missing or empty event.unsigned object. #39

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

jevolk
Copy link
Contributor

@jevolk jevolk commented Feb 2, 2021

Otherwise an exception is thrown.

@jevolk
Copy link
Contributor Author

jevolk commented Feb 3, 2021

Hello, I would just like to note that the Matrix does not place prev_content under unsigned in all places where it's used (except https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-client-r0-notifications).

This might be a greater issue with the spec, and there may be workarounds in this library I haven't seen yet, but at a glance I think this may be problematic with Construct.

@tulir
Copy link
Member

tulir commented Feb 4, 2021

I think I have prev_content moving somewhere, so that part might work fine already

@tulir tulir merged commit 7171e9c into mautrix:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants