Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lot of type annotations to the code. As this alone made the type checker not happy, additionally some smaller changes were made:
puppet
variable changed todbpuppet
)NewType
s (MatrixUserId
,MatrixRoomId
,MatrixEventId
,TelegramId
,MatrixEvent
)Context
to return a type safe tuple via a propertyThis PR does not address all the Optional discrepancies as a lot of possibly-None variables are currently accessed. Fixing this is not as easy as the rest as it is heavily related to execution logic and error handling, but I might do some smaller PRs regarding these.
For typechecking I used mypy and disabled the checking for errors with Optional. Sadly, I did only check for python 3.7 as mypy does not handle the future-fstrings in 3.5 well. This is the configuration I used:
I did test the changes on my server and it survived real-world usage of a few persons.