Add power level override to allow enabling encryption with custom PL #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
Dec 23, 2020
I overlooked a thing like 10 lines down... Co-authored-by: Tulir Asokan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #471 by adding an
encryptionoverride to the group power levels (could also be added to user but I'm not sure that's necessary). Will default to 50 so chat moderators can enable encryption, or 99 if encryption is not enabled for this bridge (so people do not accidentally enable encryption and break their rooms).The biggest problem is that this is not reverse compatible with old rooms, so powerlevels will still have to be set manually there, no idea how to approach that though.