enable delivery receipts in unencrypted rooms #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…als. Fixes mautrix#483" This reverts commit a4595b4. Commit a4595b4 avoids sending delivery receipts to rooms that do not contain the bridge bot. That was necessary as trying to send a read marker would automatically attempt to join the bridge bot to the room. That join without invite would fail, hence mautrix#483. But since mautrix/python@f272f16 we no longer attempt to join the sender of read receipts, fixing mautrix#483 without necessarily sacrificing the delivery receipt functionality. Thus: - a4595b4 is no longer necessary, its original purpose is fulfilled by f272f16. - a4595b4 prevents delivery receipts from working in unencrypted rooms. - This reverts a4595b4, thus enabling delivery receipts in unencrypted rooms.
|
I have tested this on a live instance and as far as I can tell, things seem to work. |
tulir
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a4595b4.
Commit a4595b4 avoids sending delivery receipts to rooms that do not contain the bridge bot. That was necessary as trying to send a read marker would automatically attempt to join the bridge bot to the room.
That join without invite would fail, hence #483.
But since mautrix/python@f272f16 we no longer attempt to join the sender of read receipts, fixing #483 without necessarily sacrificing the delivery receipt functionality.
See also mautrix-signal, which provides delivery receipts without the check removed in this commit.
Thus: