core: fix incoming messages by sysid #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a recent regression after a refactoring where messages from different systems are no longer filtered according to the source system ID and instead are distributed to all systems. Signed-off-by: Julian Oes <[email protected]>
Previously, we tried to use one message handler in MavsdkImpl for everything. However, this didn't work because command handlers would register for messages on construction when (for the dummy system 0) which was then wrong, once an actual system is discovered. This goes back to having a 0/dummy system by default. Maybe that's wrong, but anyway, moving the message handlers back and doing the system ID check outside in MavsdkImpl, fixes this problem. Signed-off-by: Julian Oes <[email protected]>
JonasVautherin
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a recent regression after a refactoring where messages from different systems are no longer filtered according to the source system ID and instead are distributed to all systems.
Fixes #2191.