Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: remove various hacks/workarounds #2370

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

julianoes
Copy link
Collaborator

This removes some of the hacks which were required in the past:

  • Calibration health using params as this should be covered by system status now.
  • Position validity based on system status instead of GPS magic.
  • HITL workarounds that should also be taken care of autopilot internal.

Closes #2318

This removes some of the hacks which were required in the past:
- Calibration health using params as this should be covered by system
  status now.
- Position validity based on system status instead of GPS magic.
- HITL workarounds that should also be taken care of autopilot internal.
Copy link

Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah! Those were a bit of an inconvenience!

Does this change require a minimum version of PX4/Ardupilot?

@julianoes
Copy link
Collaborator Author

julianoes commented Aug 11, 2024

Does this change require a minimum version of PX4/Ardupilot?

Presumably, no idea...

@ykhedar do you know?

@JonasVautherin
Copy link
Collaborator

Fine for me anyway, I was just curious!

@JonasVautherin JonasVautherin merged commit a428ee9 into main Aug 12, 2024
32 checks passed
@JonasVautherin JonasVautherin deleted the pr-telemetry-cleanup branch August 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old calibration params
2 participants