get_all_params fixes #2468
Merged
get_all_params fixes #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out the logic to check which params were missing was broken. This would retransmit way too many parameters, so the process takes longer but would still end successful, eventually.
When downloading params over a SiK radio there can be bursts where many params arrive, and longer periods where we have to wait. Therefore, wait a bit before triggering the retransmission.
This comes with index -1, so it's confusing.
This fixes the logic of retransmission in case we started retransmitting too early and are still receiving parameters from the initial burst. In that case, we accept whatever comes in, while also requesting what we haven't yet received.
Instead of requesting the parameters which were missed in the initial burst one by one, we can now request them in chunks, e.g. 10 at a time. This speeds up the process quite a bit.
|
JonasVautherin
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several fixes to improve/fix getting all parameters, especially using a low bandwidth radio such as an SiK radio.
The main fixes are: