Find openssl with older cmake version #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation to use the directory within third_party as well.
This copies FindOpenSSL.cmake which comes with cmake 3.28.3 and uses it for the find_package in mavsdk_server as well as curl. This is required because earlier versions don't work properly which causes linking errors on Ubuntu 22.04.
julianoes
force-pushed
the
pr-fix-cmake-openssl
branch
from
c806609 to
b6bc1cc
Compare
|
|
@JonasVautherin let me know if you're ok with this. |
JonasVautherin
approved these changes
Jan 9, 2025
|
@JonasVautherin I assume it's specific to *nix, not sure. |
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/mavsdk-doesnt-build-on-ubuntu-22-04-ssl-link-error/43223/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies FindOpenSSL.cmake which comes with cmake 3.28.3 and uses it for the find_package in mavsdk_server as well as curl.
This is required because earlier versions don't work properly which causes linking errors on Ubuntu 22.04.
Should fix #2489.