Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PX4 Setup - Power: Fix broken voltage/current divider calculators #9115

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

DonLakeFlyer
Copy link
Contributor

Broken by previous multi-battery pull

@DonLakeFlyer DonLakeFlyer merged commit 1e000bf into mavlink:master Oct 16, 2020
@DonLakeFlyer DonLakeFlyer deleted the BatCalculators branch October 16, 2020 22:36
@bys1123
Copy link

bys1123 commented Oct 18, 2020

Fixed PX4/PX4-Autopilot#15986

@bys1123
Copy link

bys1123 commented Oct 18, 2020

Do you have any idea that why old 3.5.6 version can‘t load these new BATn_* parameters? Thanks!

@DonLakeFlyer
Copy link
Contributor Author

Do you have any idea that why old 3.5.6 version can load these new BATn_* parameters?

It can't. The firmware syncs BAT1_* params to BAT_ behind the scenes.

@bys1123
Copy link

bys1123 commented Oct 18, 2020

Oh, can't, right, sorry, typo.
So, new firmware can't compatible on battery settings/messages with old QGC? It didn't syncs BAT_* params to BAT1_* backwards.

@DonLakeFlyer
Copy link
Contributor Author

It didn't syncs BAT_* params to BAT1_* backwards.

I believe there is still a bug on that in firmware which was fixed here: PX4/PX4-Autopilot#15985.

Stable should be able to sort of work with single battery setup if the firmware parameter sync stuff works correctly. It is missing setup for BAT1_SOURCE though so in reality not so sure if that causes a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants