Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Support Electron 7 #250

Merged
merged 5 commits into from
Oct 23, 2019
Merged

feat!: Support Electron 7 #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82b732e
Remove deprecated stuff
amaury1093 Oct 23, 2019
7edcbb5
Update to Electron 7
amaury1093 Oct 23, 2019
6b5de58
Fix tests
amaury1093 Oct 23, 2019
2924b8c
Add message for compatibility with Electron
amaury1093 Oct 23, 2019
a4f6408
Clean some code
amaury1093 Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,14 @@ The `Menubar` class is an event emitter:
- `after-close` - after the `.window` (BrowserWindow) property has been deleted
- `focus-lost` - emitted if always-on-top option is set and the user clicks away

## Compatibility with Electron

| menubar | Electron |
| -------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- |
| 7.x.x | 7.x.x |
| 6.x.x | 4.x.x \| 5.x.x \| 6.x.x (not recommended for [security reasons](https://electronjs.org/docs/tutorial/security#17-use-a-current-version-of-electron)) |
| <= 5.x.x | Please, _please_ don't use these old versions |

## API Docs

See the reference [API docs](./docs/globals.md).
Expand Down
4 changes: 2 additions & 2 deletions examples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"name": "example-menubar",
"version": "0.1.0",
"description": "Example menubar electron app",
"description": "Examples of menubar electron apps",
"private": true,
"workspaces": [
"arrow",
"hello-world",
"native-menu"
],
"devDependencies": {
"electron": "^6.0.0"
"electron": "^7.0.0"
}
}
Loading