Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show window on dock icon click #279

Merged
merged 3 commits into from
Apr 27, 2020
Merged

Conversation

RobbieTheWagner
Copy link
Contributor

Closes #278

@RobbieTheWagner
Copy link
Contributor Author

@amaurymartiny it keeps telling me this.app.on is not a function. Any ideas?

@amaury1093
Copy link
Collaborator

Ah yeah, for tests, we mock the Electron app object. In src/mocks/electron.ts, could you please add:

export const app = {
  getAppPath: jest.fn(() => MOCK_APP_GETAPPPATH),
  isReady: (): Promise<void> => Promise.resolve(),
+  on: (): void => {
+   /* Do nothing */
+  }
};

@RobbieTheWagner
Copy link
Contributor Author

@amaurymartiny updated, thanks!

@amaury1093 amaury1093 merged commit a8607fa into max-mapper:master Apr 27, 2020
@RobbieTheWagner
Copy link
Contributor Author

@amaurymartiny thanks for merging! When do you think a new release will be out with these changes?

@amaury1093
Copy link
Collaborator

8.0.2 is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should the dock icon open the app?
2 participants