Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stable sort in heapq.merge: python uses both __eq__ and __lt__ to… #112

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

ybungalobill
Copy link
Contributor

… compare tuples.

resolves #111

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5635ded) 99.08% compared to head (8a9bb19) 99.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files          20       20           
  Lines        2075     2077    +2     
  Branches      321      321           
=======================================
+ Hits         2056     2058    +2     
  Misses         11       11           
  Partials        8        8           
Files Coverage Δ
asyncstdlib/heapq.py 98.85% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxfischer2781 maxfischer2781 self-requested a review September 2, 2023 10:35
@maxfischer2781
Copy link
Owner

Thanks for the changes! I will look over that during the next days but at first glance it looks fine.

Feel free to disregard the failing MyPy check; you can add a # type: ignore comment for the entire method if you want to fix it yourself.

Copy link
Owner

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go. Feel free to add the suggested type-ignore rule, otherwise I'll merge it as-is once I have time for a release.

asyncstdlib/heapq.py Outdated Show resolved Hide resolved
ignore MyPy violation errors as suggested.

Co-authored-by: Max Fischer <[email protected]>
@ybungalobill
Copy link
Contributor Author

@maxfischer2781 I resolved the issue as you suggested; I'll appreciate if you could merge. Can we expect a release soon?

@maxfischer2781 maxfischer2781 merged commit c6742d7 into maxfischer2781:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asyncstdlib.heapq.merge is not stable
2 participants