Skip to content

Commit

Permalink
fix: move textOverflow to the text of the button, fixing incorrect re…
Browse files Browse the repository at this point in the history
…ndering
  • Loading branch information
maxholman committed Jan 14, 2023
1 parent d952dba commit 1986ddf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/buttons.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ const ButtonInternal: FC<
className,
icon,
inline,
textOverflow = 'ellipsis',
children,
...props
}) => (
Expand All @@ -78,7 +79,6 @@ const ButtonInternal: FC<
className,
)}
space="nano"
textOverflow="ellipsis"
{...props}
>
{icon && (
Expand All @@ -89,6 +89,7 @@ const ButtonInternal: FC<
<Box
className={[busy && visiblyHiddenClass, withIconClass]}
aria-hidden={busy || undefined}
textOverflow={textOverflow}
>
{children}
</Box>
Expand Down

0 comments on commit 1986ddf

Please sign in to comment.