fix: remove magic and always use an a component unless caller speci…

…fies something else
maxholman · Dec 26, 2022 · 9685396 · 9685396
1 parent 9c6f6ac
commit 9685396
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/links.tsx b/lib/links.tsx
@@ -8,10 +8,15 @@ export const TextLink: FC<
     BoxBasedComponentProps<'span' | 'a'>,
     { href?: string; weight?: LinkVariant }
   >
-> = ({ children, className, weight = 'standard', ...props }) => (
+> = ({
+  component = 'a',
+  children,
+  className,
+  weight = 'standard',
+  ...props
+}) => (
   <Box
-    // if someone is trying to use this as a link, use an anchor element
-    component={'href' in props ? 'a' : 'span'}
+    component={component}
     className={[linkStyleVariant[weight], className]}
     {...props}
   >