Add svg style support. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thought about building a StyleSheet for react-native, if it can work with react-native-svg. Haven't worked with svg on web much yet, but looks like <style> tags could be supported out of the box with the ReactDOM. Will try to experiment a bit more today, while I'm still thinking about this. |
…t-native-svg, etc.
…using --reactNative; useful for colored svg icons.
|
Quick test of web style tags didn't work out. Still likely something worth looking at, as well as using react-native StyleSheet, but don't really have a use case for either right now. I added a --color prop here which helps work with svg icons as buttons, etc. |
maximalism2
requested changes
Jun 12, 2017
|
Master merged. |
|
@TheTekton After merging previous PR here is some conflict, so could you please merge master into your branch again? |
|
@necinc master is now merged. |
# Conflicts: # lib/react-native-svg/props.js
maximalism2
approved these changes
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't written many parsers, so please excuse any naivety here. This PR uses the css parser package to set style props. When --reactNative is true, props based on react-native-svg's props.js are used to whitelist style props. Limited testing performed with a fairly complex icon set with colors in react-native.