Prevent duplicate selectors being added to reset ruleset #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we are in ES6 I would use a |
|
That's a good shout but I'd need to add the babel polyfill and I wonder if it's worth the extra code. |
|
@simonsmith ok, your call! the changes looks good to me |
|
@simonsmith Could you add changes description into unrealesed section of changelog |
|
@maximkoretskiy Done |
|
I'll just rebase this with your latest changes |
It's common to have duplicate selectors in media queries or nested selectors. This change checks to see if the selector has already been added and skips it if so.
|
@simonsmith sorry. Just pushed fix. could you resolve the conflict? |
|
Just published your changes to npm. Thank U guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a selector appeared more than once (media query, nesting) it was being duplicated in the reset ruleset. This change adds a check for the selector first.
cc @giuseppeg