Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .gitattributes #190

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Update .gitattributes #190

merged 1 commit into from
Feb 1, 2022

Conversation

reedy
Copy link
Contributor

@reedy reedy commented Feb 1, 2022

No description provided.

@reedy
Copy link
Contributor Author

reedy commented Feb 1, 2022

Is examples/benchmark.php really needed to?

@oschwald
Copy link
Member

oschwald commented Feb 1, 2022

I think it makes sense to have the examples in the GitHub tarball and zip files. Adding them here would prevent that.

There has been some debate about whether we should use .gitattributes in this matter at all. See, e.g., maxmind/MaxMind-DB-Reader-php#55.

I'll merge this for now though as it just updates the existing list to be more correct. Thanks!

@oschwald oschwald merged commit cc52ea4 into maxmind:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschwald oschwald oschwald approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reedy @oschwald