Skip to content

Commit

Permalink
Disable existing too-many-positional-arguments
Browse files Browse the repository at this point in the history
everywhere we diable too-many-arguments. These rules seem to overlap
unfortunately.
  • Loading branch information
oschwald committed Oct 7, 2024
1 parent df415c7 commit 198edcb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions geoip2/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ class ASN(SimpleModel):
autonomous_system_number: Optional[int]
autonomous_system_organization: Optional[str]

# pylint:disable=too-many-arguments
# pylint:disable=too-many-arguments,too-many-positional-arguments
def __init__(self, raw: Dict[str, Union[str, int]]) -> None:
super().__init__(raw)
self.autonomous_system_number = cast(
Expand Down Expand Up @@ -623,7 +623,7 @@ class ISP(ASN):
mobile_network_code: Optional[str]
organization: Optional[str]

# pylint:disable=too-many-arguments
# pylint:disable=too-many-arguments,too-many-positional-arguments
def __init__(self, raw: Dict[str, Union[str, int]]) -> None:
super().__init__(raw)
self.isp = cast(Optional[str], raw.get("isp"))
Expand Down
2 changes: 1 addition & 1 deletion geoip2/records.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"""

# pylint:disable=too-many-arguments,too-many-instance-attributes,too-many-locals
# pylint:disable=too-many-arguments,too-many-positional-arguments,too-many-instance-attributes,too-many-locals

import ipaddress

Expand Down
6 changes: 3 additions & 3 deletions geoip2/webservice.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def __init__(
timeout: float,
) -> None:
"""Construct a Client."""
# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments
if locales is None:
locales = ["en"]

Expand Down Expand Up @@ -260,7 +260,7 @@ class AsyncClient(BaseClient):
_existing_session: aiohttp.ClientSession
_proxy: Optional[str]

def __init__( # pylint: disable=too-many-arguments
def __init__( # pylint: disable=too-many-arguments,too-many-positional-arguments
self,
account_id: int,
license_key: str,
Expand Down Expand Up @@ -423,7 +423,7 @@ class Client(BaseClient):
_session: requests.Session
_proxies: Optional[Dict[str, str]]

def __init__( # pylint: disable=too-many-arguments
def __init__( # pylint: disable=too-many-arguments,too-many-positional-arguments
self,
account_id: int,
license_key: str,
Expand Down

0 comments on commit 198edcb

Please sign in to comment.