Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Support Electron 7 #250

Merged
merged 5 commits into from
Oct 23, 2019
Merged

feat!: Support Electron 7 #250

merged 5 commits into from
Oct 23, 2019

Conversation

amaury1093
Copy link
Collaborator

@amaury1093 amaury1093 commented Oct 23, 2019

fixes #243

BREAKING CHANGE:

  • Drop support for Electron 4, 5, and 6.
  • Remove deprecated passing string argument to menubar, use dir field instead
- menubar('/home/me/MY_ABSOLUTE_PATH');
+ menubar({ dir: '/home/me/MY_ABSOLUTE_PATH' });
  • Remove deprecated passing x, y, height, width, alwaysOnTop fields to menubar, pass them instead into the browserWindow field
- menubar({
-   x: 12,
-   y: 34,
-   height: 500,
-   width: 320,
-   alwaysOnTop: true
- });
+ menubar({
+   browserWindow: {
+     x: 12,
+     y: 34,
+     height: 500,
+     width: 320,
+     alwaysOnTop: true
+  }
+ });

@amaury1093 amaury1093 added the wip Work in Progress label Oct 23, 2019
@amaury1093 amaury1093 changed the base branch from am-eslint to master October 23, 2019 17:40
@amaury1093 amaury1093 removed the wip Work in Progress label Oct 23, 2019
@amaury1093 amaury1093 merged commit b54dce5 into master Oct 23, 2019
@amaury1093 amaury1093 deleted the am-electron-7 branch October 23, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron 6: 'setHighlightMode function' is deprecated and will be removed.
1 participant