Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: migrate queue to application commands #373

Merged
merged 43 commits into from
Jul 1, 2022
Merged

Feat: migrate queue to application commands #373

merged 43 commits into from
Jul 1, 2022

Conversation

maybeanerd
Copy link
Owner

@maybeanerd maybeanerd commented Jun 19, 2022 •
edited
Loading

things still to do / figure out

  • moving queue state to DB to make them continue-able;
  • probably in addition to the above, move buttonInteraction listeners to global interaction listeners
  • add timeout of queues after 2h -> removed time limit all together
  • give "extend queue" command functionality
  • muting/voice channel permissions -> decided to just not do this anymore
  • add Limit to queue size (e.g. 100?)
  • add rimraf dist to build
  • fix bug where sometimes users are not supposed to be kept in queue but still somehow exist in DB after "next" user has been used -> might be fixed, validate
  • Test!
  • last feature: make the queue end command also change the original message by getting a message ID during setup
  • make active/current user Part of Queue - they can leave, and can be removed via nextUser

bugs found:

  • data seems to not be persisted in DB

This was linked to issues Jun 19, 2022
Allow all admins to manage Queue #276
Closed
Feat: command to end queue #119
Closed
maybeanerd added 16 commits June 19, 2022 23:05
@maybeanerd
actually add queue command to / handler
5672288
@maybeanerd
remove incorrect duplicate defer
af7a20a 
admin commands are always deferred
@maybeanerd
rework defer/reply of buttonInteraction use, rename variable to make …
e80f4c3 
…it a bit clearer
@maybeanerd
formatting; error message ephemeral
662df45
@maybeanerd
remove ephemeral tag as it seems to be ignored in this case anyways
4d7cff6
@maybeanerd
feat: added functionality to queue stop
a06310e
@maybeanerd
fix: add followup to successful queue stop
85a089c
@maybeanerd
Merge branch 'main' into feat/-migrate-queue-to-application-commands
e3d931c
@maybeanerd
fix: use of reply/followup in queue edge cases
17676af
@maybeanerd
add dummy pages for queue stuff; add untested first definition of que…
a2ee7ac 
…ue DB structure
@maybeanerd
move joinsound command file to folder
ca4b054
@maybeanerd
fix forgotten joinsound path renames
1a4463d
@maybeanerd
fix weird import update issues
70c26a6
@maybeanerd
fix: make user Queue just include user IDs as that should be enough i…
36fa2cd 
…nformation
@maybeanerd
add first draft of DB management functions for queues
17afb3b
@maybeanerd
Update gitleaks.yml
45a2ce4
@maybeanerd
Copy link
Owner Author

maybeanerd commented Jun 25, 2022 •
edited
Loading

@all-contributors please add @7crmbs2 for userTesting

@allcontributors allcontributors bot mentioned this pull request Jun 25, 2022
Closed
@allcontributors
Copy link
Contributor

@T0TProduction

I've put up a pull request to add @crmbs! 🎉

@maybeanerd
Copy link
Owner Author

@all-contributors please add @7crmbs2 for userTesting

@allcontributors allcontributors bot mentioned this pull request Jun 25, 2022
Merged
@allcontributors
Copy link
Contributor

@T0TProduction

I've put up a pull request to add @7crmbs2! 🎉

@maybeanerd
Copy link
Owner Author

should be ready for testing now

maybeanerd added 17 commits June 27, 2022 20:32
@maybeanerd
fix: add maximumQueueLength
fc95367
@maybeanerd
chore: code cleanup
eb59fbb
@maybeanerd
Merge branch 'main' into feat/-migrate-queue-to-application-commands
4db9b6a
@maybeanerd
feat: use rimraf to clean dist on build
ef5c1e5
@maybeanerd
fix: use shared functions for mentioning users and roles across all f…
7c26bf0 
…iles
@maybeanerd
fix: bugfixes where queue state was behaving weirdly
6304eda
@maybeanerd
fix: do not remove only user in queue on "next" if there are no queue…
5e27707 
…d users left
@maybeanerd
fix: if queue has only one user (who is active), that user cannot lea…
b7288c8 
…ve; reword queue message
@maybeanerd
fix: resolve some TODOs such as cleaner types with addUser in queue s…
3ec9977 
…tate manager
@maybeanerd
fix: include forgotten changes with userMention normalisation
1ddc71f
@maybeanerd
add a new TODO
a0415e6
@maybeanerd
attempt to adjust CI to run on push only on main, and always on PRs
5cfd0b2 
because currently it runs twice for all pushes on PRs
@maybeanerd
update gitleaks CI triggers to also only run once on PR
5aed2ba
@maybeanerd
Merge branch 'main' into feat/-migrate-queue-to-application-commands
52d91cd
@maybeanerd
feat: make queue end always edit the original queue message, even if …
2c722b2 
…used as command instead of the button
@maybeanerd
Merge branch 'main' into feat/-migrate-queue-to-application-commands
7a43d4e
@maybeanerd
fix: make current user part of the queue: allow them to leave or to b…
13a3962 
…e removed by next, even if they are the only one
@maybeanerd maybeanerd marked this pull request as ready for review July 1, 2022 23:24
@maybeanerd maybeanerd merged commit 7dee5a7 into main Jul 1, 2022
@maybeanerd maybeanerd deleted the feat/-migrate-queue-to-application-commands branch July 1, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow all admins to manage Queue Feat: command to end queue
1 participant
@maybeanerd