Adds support to change the line comment prefix

[chribjel]

This pull request adds an extension setting that enables the user to change which symbol(s) to use as a line comment prefix. It also adds highlighting for '#' by default. The default prefix is still ';' as to not break any configurations by previous users of the extension.

[maziac]

Which assembler does use '#'?

[maziac]

For me the change does not work. I mean the asm.json is working.
But it is not possible to change the line comment character.

[chribjel]

Which assembler does use '#'?

AT&T syntax for i386. At least the one we use at University

But i will look into it more to make it work on all platforms!

[chribjel]

It looks like the npm preLaunchTask that compiles the files are commented out, and I might suspect that the files may have not been compiled when you tested it. I uncommented that line with the latest commit.

[maziac]

No, that doesn't help either. Here I try to change the comment name but nothing happens:

I also don't understand how this should work.
There is the grammar in asm.json for all three ':', '//' and '#'.
How should the selection work?

[chribjel]

This is what i mean. When you use the keybind for adding line comment in vs code, it changes what symbol is inserted.

This pull request does not change all the characters to the desired symbol.

Sorry if that was unclear.

[maziac]

O, I misunderstood.

[maziac]

I have now merged your PR.
Thanks very much for contributing.

[maziac]

please have a look here:
#54

Seems that # is used also for hex numbers.

I think I will change the # grammar so that you need to enter a whitespace after the #, e.g.
" # comment"
but not
" #comment"
anymore.

[chribjel]

Yes, I was not aware of that. Good catch! This should be fixed.

[maziac]

Hi, I forgot to ask that. Can you add a statement in the comments that your code is MIT licensed.

[chribjel]

Hi, I forgot to ask that. Can you add a statement in the comments that your code is MIT licensed.

Not sure i understand. Where should i put this statement?

[maziac]

Just here. Re-assuring that I can use your code :-)

[chribjel]

Just here. Re-assuring that I can use your code :-)

Ah understand! Yes, you can definitely use my code, and it is MIT licensed :)

[maziac]

Thanks