Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rosé Pine colors #485

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Fix Rosé Pine colors #485

merged 2 commits into from
Dec 30, 2024

Conversation

julianolf
Copy link
Contributor

@julianolf julianolf commented Dec 29, 2024

Description

Update Rosé Pine files to fix the issues reported on #439 and #442.

The iTerm2 files for Rosé Pine theme and it's variants were downloaded from the theme's official repository at https://github.com/rose-pine/iterm

I've tested on iTerm2 and they look good.

Theme Submission Checklist

  • Included theme in iTerm2 format
  • Included 600x300 screenshot, 13pt Monaco font, no transparency
  • Updated README.md with new theme and screenshot
  • Updated CREDITS.md with new theme
  • Ran tools/gen.py to generate themes in all formats
  • Updated screenshots/README.md with new theme

@mbadolato mbadolato merged commit 2830667 into mbadolato:master Dec 30, 2024
@mbadolato
Copy link
Owner

Thank you!

@00-kat
Copy link

00-kat commented Jan 2, 2025

This PR only appears to partially fix #442 (but #439 is fixed). Rosé Pine Dawn is fixed, and the colours in Rosé Pine are untouched. Rosé Pine Moon has the brights fixed but the regular colours are untouched.

@julianolf
Copy link
Contributor Author

Hi @00-kat. I thought I had fixed both issues, but it seems I missed something.

Would you mind commenting on issue #442 and providing more details about which colors don’t seem right? Maybe I can help fix it.

@julianolf julianolf deleted the fix/rose-pine branch January 4, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants